arla-0.35.9 FreeBSD crash

[Love]

Nickolai Zeldovich <kolya at mit.edu> writes:

> I upgraded my FreeBSD remote-login server to arla 0.35.9 recently,
> and today found arlad crashed, with a failed assert.  A gdb output
> is attached.  Probably the right thing to do is to avoid an assert
> in collectstats_stop().  In general, I've always been surprised by
> the number of asserts in arla on data received from the network --
> a misbehaving or malicious fileserver could easily supply inconsistent
> records that could crash arlad.

Slowly I'm trying to kill them all to make the into runtime errors, but
this makes everything much more complicated.
 
> At a guess, perhaps what happened here is that the volume got moved
> between the collectstats_start() and _stop() calls?

Probably. This problem isn't in the current code since I reorganized
it. Just ignored if when the partiation ends up becoming -1 in the 0.35
branch.

Love