FreeBSD 4.6.2 fake-mp + dynroot oddity

[Magnus Ahltorp]

> I was curious about fake-mp and dynroot support in arla, and enabled
> both features on my FreeBSD 4.6.2 machine.  It seems to have some odd
> behavior:
> [...]
> Interestingly enough, enabling dynroot only doesn't produce this bug,
> and enabling fake-mp only doesn't produce it either (the mountpoints
> in /afs look fake, but they are VDIR rather than VLNK).  This is the
> 0.35.x branch from CVS as of a few days ago (rxdebug says 0.35.10pre4).

I have been looking at this, and I came up with this patch (against
0.35.10). I have tried it on my laptop, and as far as I can tell, it
works fine (it doesn't break more regression tests).

diff -ru orig/arla-0.35.10/arlad/dynroot.c arla-0.35.10/arlad/dynroot.c
--- orig/arla-0.35.10/arlad/dynroot.c   Mon May 28 17:19:20 2001
+++ arla-0.35.10/arlad/dynroot.c        Sun Oct 13 17:25:53 2002
@@ -280,7 +280,6 @@
     } else {
        ret = dynroot_create_symlink (&dir, entry->fid.fid.Vnode);
        entry->status.LinkCount = 1;
-       fcache_mark_as_mountpoint (entry);
     }
 
     if (ret) {
@@ -304,6 +303,9 @@
     entry->flags.datap = TRUE;
 
     entry->tokens |= XFS_ATTR_R|XFS_DATA_R;
+
+    if (!rootnode)
+       fcache_mark_as_mountpoint (entry);
 
     return 0;
 }