Some patches

[Adrian Bridgett]

On Fri, Jun 16, 2000 at 17:31:21 +0200 (+0000), Assar Westerlund wrote:
> Adrian Bridgett <adrian.bridgett at iname.com> writes:
> > --- arla-0.33.1.orig/lib/sl/ss.c
> > +++ arla-0.33.1/lib/sl/ss.c
> > @@ -32,7 +32,7 @@
> >   */
> >  
> >  #include "sl_locl.h"
> > -#include <com_err.h>
> > +#include <et/com_err.h>
> >  #include "ss.h"
> 
> We usually try to pick up the com_err.h installed by krb4.  Is it
> failing to find a com_err.h at all for you?

Yep.  I did a Debian-wide search and the only package it was in was:

Package: comerr-dev
Description: The Common Error Description library - headers and static libraries.
 libcomerr is an attempt to present a common error-handling mechanism to
 manipulate the most common form of error code in a fashion that does not
 have the problems identified with mechanisms commonly in use.
 
...and that installs it in /usr/include/et/com_err.h.

> > Two bits from the init.d - don't do anything unless we need to:
> > 
> > +    # This now seems to need to be manually loaded before arlad is started
> > +    if ! lsmod | grep "^xfs " >/dev/null; then
> > +      echo -n "Loading Xfs user-space filesystem kernel module..."
> > +      modprobe xfs
> > +      echo done
> > +    fi
> 
> This is in arla.init.in around start) ?  Seems to make sense to me.
> Unless there's a way to tell modprobe to be happy even if the module
> is already loaded.

Yep, and the bit below is around stop).

> > +    if lsmod | grep -q ^xfs ; then
> > +	echo -n "Removing Xfs user-space filesystem kernel module..."
> > +	rmmod xfs || true
> > +	echo done
> > +    else
> > +	echo "Xfs user-space filesystem kernel module not installed not removing."
> > +    fi
> 
> So this is to avoid displaying the error message that rmmod spits out
> when it does not fail the module?

Yep. Not really important, but Debian scripts are supposed to run "set -e"
so any error would stop the script.

> > on partial mirroring - someone at work has just started dumping linux .iso's
> > on AFS and at 500/600MB each I will run out of disk if I try and read them!
> 
> Yes, there are more people that have that have requested that.  It's
> on the TODO-list but we cannot promise you a date there either.

Fair enough, I just wondered what the status was.

Cheers

Adrian

email: adrian.bridgett at iname.com
Windows NT - Unix in beta-testing.   PGP key available on public key servers
Debian GNU/Linux  -*-   because I'm allergic to Prozac   -*-  www.debian.org