Some patches

Assar Westerlund assar at stacken.kth.se
Fri Jun 16 17:31:22 CEST 2000


Adrian Bridgett <adrian.bridgett at iname.com> writes:
> --- arla-0.33.1.orig/lib/sl/ss.c
> +++ arla-0.33.1/lib/sl/ss.c
> @@ -32,7 +32,7 @@
>   */
>  
>  #include "sl_locl.h"
> -#include <com_err.h>
> +#include <et/com_err.h>
>  #include "ss.h"

We usually try to pick up the com_err.h installed by krb4.  Is it
failing to find a com_err.h at all for you?

> --- arla-0.33.1.orig/lwp/Makefile.in
> +++ arla-0.33.1/lwp/Makefile.in
> @@ -104,7 +104,7 @@
>  testlwp.o: testlwp.c
>  
>  clean:
> -	rm -f *.o *.a core process.ss process.i $(LIB) make-process.o.sh $(TEST_PROGRAMS)
> +	rm -f *.o *.a core process.ss process.i $(LIB) make-process.o.sh $(TEST_PROGRAMS) testprocess
>  
>  distclean: clean
>  	rm -f Makefile

Thanks.  Added.

> Two bits from the init.d - don't do anything unless we need to:
> 
> +    # This now seems to need to be manually loaded before arlad is started
> +    if ! lsmod | grep "^xfs " >/dev/null; then
> +      echo -n "Loading Xfs user-space filesystem kernel module..."
> +      modprobe xfs
> +      echo done
> +    fi

This is in arla.init.in around start) ?  Seems to make sense to me.
Unless there's a way to tell modprobe to be happy even if the module
is already loaded.

> +    if lsmod | grep -q ^xfs ; then
> +	echo -n "Removing Xfs user-space filesystem kernel module..."
> +	rmmod xfs || true
> +	echo done
> +    else
> +	echo "Xfs user-space filesystem kernel module not installed not removing."
> +    fi

So this is to avoid displaying the error message that rmmod spits out
when it does not fail the module?

> I don't suppose there is any ETA on either shared libraries (I see that
> quite a few of the makefiles have some support, it's just commented out);

Sorry, no ETA.  I think the current plan is to automake:ize and
libtool:ify and thus get shared libraries `for free'.

> on partial mirroring - someone at work has just started dumping linux .iso's
> on AFS and at 500/600MB each I will run out of disk if I try and read them!

Yes, there are more people that have that have requested that.  It's
on the TODO-list but we cannot promise you a date there either.

/assar





More information about the Arla-drinkers mailing list