appl/arlalib.c's arlalib_get_cred() problems

[Assar Westerlund]

John Hawkinson <jhawk at bbnplanet.com> writes:
> Can't there be a better way? Like looking it up in /etc/name_to_sysnum
> dynamically? Sure, this is less efficient than hardcoding it, but
> isn't it "the right solution"?

Could you try the following patch?

/assar

Index: lib/kafs/afssys.c
===================================================================
RCS file: /afs/pdc.kth.se/src/packages/kth-krb/SourceRepository/lib/kafs/afssys.c,v
retrieving revision 1.59
diff -u -w -u -w -r1.59 afssys.c
--- afssys.c	1998/06/30 15:25:09	1.59
+++ afssys.c	1998/07/02 14:37:50
@@ -90,6 +90,40 @@
 }
 #endif /* _AIX */
 
+/* 
+ * This probably only works under Solaris and could get confused if
+ * there's a /etc/name_to_sysnum file.  
+ */
+
+#define _PATH_ETC_NAME_TO_SYSNUM "/etc/name_to_sysnum"
+
+static int
+map_syscall_name_to_number (const char *str, int *res)
+{
+    FILE *f;
+    char buf[256];
+    size_t str_len = strlen (str);
+
+    f = fopen (_PATH_ETC_NAME_TO_SYSNUM, "r");
+    if (f == NULL)
+	return -1;
+    while (fgets (buf, sizeof(buf), f) != NULL) {
+	if (strncmp (str, buf, str_len) == 0) {
+	    char *begptr = buf + str_len;
+	    char *endptr;
+	    long val = strtol (begptr, &endptr, 0);
+
+	    if (val != 0 && endptr != begptr) {
+		fclose (f);
+		*res = val;
+		return 0;
+	    }
+	}
+    }
+    fclose (f);
+    return -1;
+}
+
 #define NO_ENTRY_POINT		0
 #define SINGLE_ENTRY_POINT	1
 #define MULTIPLE_ENTRY_POINT	2
@@ -252,7 +286,8 @@
     char *env = getenv ("AFS_SYSCALL");
   
     /*
-     * Already checked presence of AFS syscalls?  */
+     * Already checked presence of AFS syscalls?
+     */
     if (afs_entry_point != UNKNOWN_ENTRY_POINT)
 	return afs_entry_point != NO_ENTRY_POINT;
 
@@ -273,9 +308,13 @@
     {
 	int tmp;
 
-	if (env != NULL && sscanf (env, "%d", &tmp) == 1)
+	if (env != NULL) {
+	    if (sscanf (env, "%d", &tmp) == 1
+		|| map_syscall_name_to_number (env, &tmp) == 0) {
 	    if (try_one (tmp) == 0)
 		goto done;
+	    }
+	}
     }
 #endif /* AFS_SYSCALL || AFS_SYSCALL2 || AFS_SYSCALL3 */