Compiling problems on SMP FreeBSD

[Love]

Quincey Koziol <koziol at ncsa.uiuc.edu> writes:

> > >     This is from the FreeBSD header files, which want "APIC_IO" to be defined
> > > when "SMP" is defined.  (My configure line was "./configure --enable-smp").
> > > My fix at this point is to go to the xfs/bsd Makefile and add "-DAPIC_IO" to
> > > the CFLAGS macro.  Can someone either add this to the Makefile.in for the
> > > next release, or (possibly a more correct solution) change the "SMP" macros
> > > in arla to be more arla-specific, like maybe "ARLA_SMP"?
> > 
> > The filesystemcode in arla (xfs) doesn't contain any #ifdef on SMP in the
> > code, I think this its part of the glorious battle to find what cpp flags
> > we need to compile for this kernel.
> > 
> > Is it correct to assume that all freebsd4.x and freebsd5 will be happy with
> > -DAPIC_IO ? If so, the patch below should be ok. Can you test it ?
>
>     Unfortunately, the -DAPIC_IO isn't being passed down to the makefile in
> xfs/bsd with this patch....  Any other things to try?

Did you rerun autoconf after applying the patch ?

Here is an updated patch that does the right thing when --enable-smp isn't
given to the configure script.

Love

Index: configure.in
===================================================================
RCS file: /afs/stacken.kth.se/src/SourceRepository/arla/configure.in,v
retrieving revision 1.465.2.56
diff -u -w -u -w -r1.465.2.56 configure.in
--- configure.in	2001/10/16 21:43:55	1.465.2.56
+++ configure.in	2001/10/20 19:26:14
@@ -70,7 +70,7 @@
 else
   smp="no"
 fi
-])
+],[smp="no"])
 
 AC_ARG_ENABLE(kld,
 [  --enable-kld            build kld modules (only FreeBSD 3.0)],
@@ -325,6 +325,9 @@
 changequote([,])dnl
 	if test "X$kld" = "X"; then
 		kld="yes";
+	fi
+	if test "$smp" != "no"; then
+		smp="-DAPIC_IO $smp"
 	fi
 	;;
   esac