cores in new 0.35 (Re: arla 0.35)

[Love]

Karl Kleinpaste <karl at charcoal.com> writes:

> At the time, I was doing a "cp -p <bunch of files> <afs directory>",
> and because I'm on a slow link, I had cd'd into the same directory in
> another shell to do an "ls -l" on it, to observe progress.  All my
> terminals were simultaneously informed of:
>         Message from syslogd at cinnamon at Sat Jan 27 22:14:55 2001 ...
>         cinnamon kernel: xfs_readdir: data not valid: -19 
> at the time of the core.

Can you try this patch ?

If it fixes your problem I'll cook another release.

-19 is -ENODEV and is what xfs returnes when arla dies, and since there is
real no point in returning errors i xfs_readdir() (since userland readdir
can't return errors) we print an error.

Love


Index: xfs_inodeops.c
===================================================================
RCS file: /afs/stacken.kth.se/src/SourceRepository/arla/xfs/linux/xfs_inodeops.c,v
retrieving revision 1.150
retrieving revision 1.151
diff -u -w -u -w -r1.150 -r1.151
--- xfs/linux/xfs_inodeops.c	2001/01/14 01:45:02	1.150
+++ xfs/linux/xfs_inodeops.c	2001/01/28 16:10:42	1.151
@@ -455,6 +455,8 @@
 	return ERR_PTR(-ENODEV);
     }
 
+    do {
+
     msg.header.opcode = XFS_MSG_GETNODE;
         
     msg.cred.uid = current->uid;
@@ -463,7 +465,6 @@
         
     strlcpy(msg.name, dentry->d_name.name, sizeof(msg.name));
 
-    do {
 	new_dentry = d_lookup(dentry->d_parent, &dentry->d_name);
 
 	if (new_dentry && DENTRY_TO_XDENTRY(new_dentry)->valid)