help a fool

[Ernst Jeschek]

On Fri, Mar 24, 2000 at 12:58:52PM +0000, Dr A V Le Blanc wrote:
> Ouch!  This is what the WEXITSTATUS(retcode) is supposed to stop,
> as well as failed logins.  I suppose I can see what return code
> this produces with my libc.

I think the return code is 0, if klog has succeeded. So maybe this patch
could solve the problem:


cvs rdiff: Diffing libpam_afs
*** libpam_afs/pam_auth.c:1.1	Thu Mar 23 11:12:10 2000
--- libpam_afs/pam_auth.c	Fri Mar 24 17:23:13 2000
***************
*** 69,80 ****
  	close(piped[0]);
  	while (wait(&retcode) != child);
  
! 	if (WEXITSTATUS(retcode) &&	/* No AFS authentication; UNIX? */
! 		strcmp(crypt(pass, pw->pw_passwd), pw->pw_passwd))
  	    return PAM_AUTHTEST_FAIL;
      }
  
!     return PAM_SUCCESS;
  }
  
  int pam_sm_setcred(void) {
--- 69,87 ----
  	close(piped[0]);
  	while (wait(&retcode) != child);
  
! 	if (retcode == 0)
! 	    return PAM_SUCCESS;
! 	else
  	    return PAM_AUTHTEST_FAIL;
+ 	/*
+ 	 * if (WEXITSTATUS(retcode) &&	/* No AFS authentication; UNIX? */
+ 	/*
+ 	 * strcmp(crypt(pass, pw->pw_passwd), pw->pw_passwd)) {
+ 	 *     return PAM_AUTHTEST_FAIL;
+ 	 */
      }
  
!     /* return PAM_SUCCESS; */
  }


kind regards
jeschek

-- 
Ernst.Jeschek at wu-wien.ac.at                      Fax: +43/1/31336/702
Zentrum fuer Informatikdienste, Wirtschaftsuniversitaet Wien, Austria