klog -pipe does not allow spaces

Tino Schwarze tino.schwarze at informatik.tu-chemnitz.de
Thu Jun 22 14:30:04 CEST 2000


Hi Brandon,

On Thu, Jun 22, 2000 at 08:23:32AM +0000, Brandon S. Allbery KF8NH wrote:
> +-----
> | Hi there,
> | a friend of mine recently figured out that klog -pipe does not accept
> | spaces within passwords. He hunted the problem down to the use of
> | scanf() in line 654 of klog.c.
> +--->8
> 
> **ick**
> 
> I'd like to shoot anyone who uses scanf() or fscanf().  It's almost always 
> the wrong thing to do.
> 
> | 1. use getchar and figure out end-of-line ourself
> +--->8
> 
> klog doesn't need to use raw mode, so EOL should be presented as \n.
It is not about raw mode but its about \n vs. \r\n (e.g. on OS/2, Win*)
or even more weird eol markers. (Not sure whether they exist)

Bye, Tino.

-- 
             * LINUX - Where do you want to be tomorrow? *





More information about the Arla-drinkers mailing list