Debugging arla on FreeBSD 4.0

[Assar Westerlund]

Robert Ricci <ricci at siren.eng.utah.edu> writes:
> Looks to me like the queue for the channel filled up, with more
> than 2^16 bytes of messages to send. The message that caused the
> core dump was sent by xfs_reclaim, so maybe this happened during
> a period of cache cleaning?

It seems like the code in xfs_devread() does the wrong thing.  Does
this patch look good?  And/or does it work? :)

/assar

Index: xfs_dev-common.c
===================================================================
RCS file: /afs/stacken.kth.se/src/SourceRepository/arla/xfs/bsd/xfs_dev-common.c,v
retrieving revision 1.30
diff -u -w -u -w -r1.30 xfs_dev-common.c
--- xfs_dev-common.c	2000/03/19 00:22:26	1.30
+++ xfs_dev-common.c	2000/04/01 07:38:50
@@ -226,6 +227,9 @@
 	    XFSDEB(XDEBDEV, ("xfs_devread: message->size = %u\n",
 			     first->message->size));
 	    
+	    if (first->message->size > uiop->uio_resid)
+		break;
+
 	    error = uiomove((caddr_t) first->message, first->message->size, 
 			    uiop);
 	    if (error)