Patch for linux xfs driver
Magnus Ahltorp
map at stacken.kth.se
Fri Oct 16 02:00:29 CEST 1998
> I've been having trouble with the odd spurious Oops when running
> ARLA 0.13 on a linux 2.1.125 kernel. I think I've tracked it down to
> various 'IS_ERR' macros 'Oops'ing due to positive error-values being
> returned by ARLA routines.
>
> Would somebody knowledgeable of ARLA internals please check the
> following patch to 'xfs/linux' for correctness?
FYI, this was fixed a week ago. We are making a new release soon.
I have fixed it in another way:
Index: xfs_dev.c
===================================================================
RCS file: /usr/local/cvsroot/arla/xfs/linux/xfs_dev.c,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- xfs_dev.c 1998/10/02 04:40:30 1.25
+++ xfs_dev.c 1998/10/09 04:27:50 1.26
@@ -537,7 +537,10 @@
}
else {
memmove(t->message, message, size);
- t->error_or_size = -message->error;
+ if (message->error < 0)
+ t->error_or_size = -EPROTO;
+ else
+ t->error_or_size = -message->error;
}
if (t->wait_queue)
wake_up(&t->wait_queue);
@@ -565,7 +568,10 @@
}
else {
memmove(t->message, message, size);
- t->error_or_size = -message->error;
+ if (message->error < 0)
+ t->error_or_size = -EPROTO;
+ else
+ t->error_or_size = -message->error;
}
if (t->wait_queue)
wake_up(&t->wait_queue);
More information about the Arla-drinkers
mailing list